Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dracula refactoring #6767

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

Chirikumbrah
Copy link
Contributor

@Chirikumbrah Chirikumbrah commented Apr 15, 2023

Sat_15 04 2023_19-35
Sat_15 04 2023_21-01

I changed the colors according to the official Dracula specifications and vscode theme and I hope u'll like it :)
As I said earlier, I'm open to any ideas :)

@the-mikedavis
Copy link
Member

cc @loewenheim what do you think?

@loewenheim
Copy link
Contributor

Sorry, I'm a little lost. Which colors is this changing to agree with the spec? Variable colors are still different.

@Chirikumbrah
Copy link
Contributor Author

Chirikumbrah commented Apr 18, 2023

@loewenheim As you can see, the color of the variable is now white.
image

Builtins (variable.builtin) are purple and italic, according to VS Code config.
image

Function parameters (variable.parameter) are orange and italic, according to VS Code config and dracula specs.
image

I made 'variable.other' cyan, but didn't see any changes and left it as is for now.
The 'variable.other.member' is now purple because I couldn't find any info about the color of this option, so you can suggest me something about that and I'll make a change :)

@loewenheim
Copy link
Contributor

Right, I see. Thank you for the explanation. To be honest I would leave members as foreground, the same as other variables. Apart from that, this looks good :)

@Chirikumbrah
Copy link
Contributor Author

Chirikumbrah commented Apr 20, 2023

@loewenheim No problem)
Thank you)

@archseer archseer merged commit 2342807 into helix-editor:master Apr 21, 2023
@truongvan
Copy link

I love your work, but I prefer ui.menu is more contrast with default background.

Screenshot 2023-04-23 at 10 30 43

@Chirikumbrah
Copy link
Contributor Author

@truongvan, thank you so much :)
U can see desired changes in my new pull request)

@mo8it
Copy link
Contributor

mo8it commented Apr 27, 2023

@Chirikumbrah Thank you :)

Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants