-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another dracula refactoring #6767
Conversation
cc @loewenheim what do you think? |
Sorry, I'm a little lost. Which colors is this changing to agree with the spec? Variable colors are still different. |
@loewenheim As you can see, the color of the variable is now white. Builtins (variable.builtin) are purple and italic, according to VS Code config. Function parameters (variable.parameter) are orange and italic, according to VS Code config and dracula specs. I made 'variable.other' cyan, but didn't see any changes and left it as is for now. |
Right, I see. Thank you for the explanation. To be honest I would leave members as |
@loewenheim No problem) |
@truongvan, thank you so much :) |
@Chirikumbrah Thank you :) |
I changed the colors according to the official Dracula specifications and vscode theme and I hope u'll like it :)
As I said earlier, I'm open to any ideas :)