Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion on paths containing spaces #6779

Merged

Conversation

p13l13d13
Copy link
Contributor

It solves #5779

Before:
render1681600147669

After:

render1681600980390

P.S. I fixed this by getting word_len for a range replacement from the actual word being displayed (instead of initial representation of a path from autocomp), hope that was an initial idea here.

@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-medium Call for participation: Experience needed to fix: Medium / intermediate S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 18, 2023
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
@p13l13d13 p13l13d13 force-pushed the whitespace-path-autocomplete-fix branch from 080e72a to 47c69d0 Compare April 23, 2023 14:14
@p13l13d13
Copy link
Contributor Author

Fixed the issues with 'cargo fmt' :)

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@archseer archseer merged commit 2cccb3f into helix-editor:master May 18, 2023
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
There was an issue with autocompletion of a path with a space in it.

Before:

:o test\ dir -> <TAB> -> test\ dirfile1

After:

:o test\ dir -> <TAB> -> test\ dir\file1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug E-medium Call for participation: Experience needed to fix: Medium / intermediate S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants