WIP for LSP "rename symbol" #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSP uses 1-indexed lines, we use 0-indexed lines. Looks like it's not too hard to implement, besides edits there's a few commands to create/delete/rename files: https://github.com/kak-lsp/kak-lsp/blob/4f24f0f1cb3689d86d68e0463ab0f191a8166ba1/src/workspace.rs#L138-L241 |
Closed
Closed
|
This was implemented in #1011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says.
The server is currently giving and error of
Invalid params: No references found at positionwhich I don't understand why...I also notice a off-by-one mismatch between the line/col reported by Helix and the ones mention on the LSP server response...?
Still missing:
WorkspaceEditresult from the server into the workspace.