add move_prev_long_word_end and extend_prev_long_word_end commands #6905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vwkd
commented
Apr 28, 2023
Comment on lines
+180
to
+183
| pub fn move_prev_word_end(slice: RopeSlice, range: Range, count: usize) -> Range { | ||
| word_move(slice, range, count, WordMotionTarget::PrevWordEnd) | ||
| } | ||
|
|
There was a problem hiding this comment.
This just moved up from below where it was out of sequence.
vwkd
commented
Apr 28, 2023
Comment on lines
+1462
to
+1464
| ("Starting from after boundary retreats the anchor", | ||
| vec![(1, Range::new(0, 9), Range::new(8, 0))], | ||
| ), |
There was a problem hiding this comment.
This was commented out in test_behaviour_when_moving_to_start_of_previous_long_words but seems to be passing here so I added it back.
the-mikedavis
approved these changes
Jun 7, 2023
pascalkuthe
approved these changes
Jun 7, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6904
Adds the
move_prev_long_word_endandextend_prev_long_word_endcommands.Tests are adapted from
test_behaviour_when_moving_to_start_of_previous_long_wordsof themove_prev_long_word_startcommand, please double check if these are correct.Here's a quick config to test the new commands with the keybinding
A-W, together withA-wfor the already existing but by default unboundmove_prev_word_end.