Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wbc and wbc! commands #6947

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

l4l
Copy link
Contributor

@l4l l4l commented May 2, 2023

Resolves #6857

I'm not sure what are the policies are there wrt to new commands but this one feels useful to me as well.

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels May 4, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I think this is fine to add. I don't use :bc myself much but I could see the use-case for these. Ideally it would be possible to build these with #4423 but that feature needs more design (and maybe the plugin system).

@pascalkuthe pascalkuthe merged commit 92c328c into helix-editor:master May 9, 2023
@l4l l4l deleted the wbc-commands branch May 9, 2023 21:19
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write and close buffer
4 participants