Highlight query improvements for java and typescript #7145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
approved these changes
May 26, 2023
pascalkuthe
approved these changes
May 26, 2023
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Add missing queries to java highlights * Fix generic type bracket highlights in typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java
Java highlights were completely missing punctuation and operator highlights. This PR adds them based on the JSE 20 language spec. Changes include:
@and...as special punctuation because those are somewhat different to the regular punctuation symbols.?as a type instead of as an operator, in the context of type arguments, according to the spec (see "4.5.1. Type Arguments of Parameterized Types").Typescript
The symbols
<and>where being highlighted as operators in the context of type arguments, and the highlight for type parameters was missing. Changes include:; inherits: ecmastatement to the bottom of the file so that the operator highlights in there don't override the highlight of<and>for type arguments and parameters (and any type highlight really).<and>in the context of type parameters.