Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: port of Zed's OneDark and OneLight themes #7250

Merged
merged 10 commits into from
Jun 22, 2023

Conversation

EricHenry
Copy link
Contributor

@EricHenry EricHenry commented Jun 6, 2023

I am a big fan of Zed's OneDark theme variation so I ported it over to helix. Here are some screen shot comparisons.

Zed
Screenshot 2023-06-06 at 10 32 46 PM

Helix:
Screenshot 2023-06-06 at 10 33 29 PM

edit: updated screenshots

@archseer
Copy link
Member

archseer commented Jun 6, 2023

How different is it from the regular one?

@EricHenry
Copy link
Contributor Author

EricHenry commented Jun 6, 2023

The color pallet and the colors used for tree sitter scopes are different. I think the only colors that are the same is the background and color used for comments.

Here are some screenshots of the current OneDark theme for reference.

OneDark of same code as above:

Screenshot 2023-06-06 at 10 38 14 PM

New code screen shots

One Dark:
Screenshot 2023-06-06 at 10 36 13 PM

Zed One Dark in Helix:
Screenshot 2023-06-06 at 10 35 39 PM

edit: updated screenshots

@EricHenry
Copy link
Contributor Author

I've updated the PR to also include Zed's OneLight theme. Here is a comparison of the current onelight theme, the Zed alternative, and the Helix port in this PR.

Current OneLight

Screenshot 2023-06-06 at 10 25 50 PM

Zed OneLight

Screenshot 2023-06-06 at 9 59 48 PM

Helix OneLight

Screenshot 2023-06-06 at 9 59 37 PM

@EricHenry EricHenry changed the title Theme: Zed's OneDark theme port Theme: port of Zed's OneDark and OneLight themes Jun 7, 2023
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 8, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like light and dark are virtually the same except for the colors. Could they be refactored into one theme where the other inherits it (https://docs.helix-editor.com/master/themes.html#inheritance) and changes the palette? For example see the gruvbox themes

@EricHenry
Copy link
Contributor Author

@the-mikedavis great idea! I'll refactor it, there is quite a bit of of overlap between the two.

@EricHenry
Copy link
Contributor Author

thanks for the suggestion @the-mikedavis , this cleaned up the light theme a lot.

the-mikedavis
the-mikedavis previously approved these changes Jun 16, 2023
@pascalkuthe pascalkuthe merged commit 842518c into helix-editor:master Jun 22, 2023
@gavlig
Copy link

gavlig commented Jun 24, 2023

I'm sorry for writing in a closed PR, but @EricHenry I need to know what is that beautiful font you're using (probably in all screenshots, but I like how it looks the most in the first post)

@EricHenry
Copy link
Contributor Author

@gavlig hey I totally get it. Haha I like beautiful fonts myself.

There are 2 fonts in the first post. The one marked Zed is from the zed editor. They built their own font (that I’m a big fan of too) called Zed Mono and Zed Sans. You can find them here: https://github.com/zed-industries/zed-fonts

The other screenshot marked helix is my other favorite font and daily driver. Cascading Code. Also free: https://github.com/microsoft/cascadia-code

@gavlig
Copy link

gavlig commented Jun 24, 2023

Thank you, much appreciated!

tqwewe pushed a commit to tqwewe/helix-tree-explorer that referenced this pull request Jun 28, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants