Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next/prev tree-sitter inconsistency #7332

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

A-Walrus
Copy link
Contributor

Fixes #7223
Before there where different results going to next or previous due to sorting not dealing with multiple captures that start/end at the same pos. I chose to prefer longer matches.

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, longer matches seems like the right default 👍

@pascalkuthe pascalkuthe merged commit a4a8612 into helix-editor:master Jun 13, 2023
rozaliev pushed a commit to rozaliev/helix that referenced this pull request Jun 13, 2023
* Fix next/prev tree-sitter inconsistency

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.

* Revert unnecessary change
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
* Fix next/prev tree-sitter inconsistency

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.

* Revert unnecessary change
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
* Fix next/prev tree-sitter inconsistency

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.

* Revert unnecessary change
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* Fix next/prev tree-sitter inconsistency

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.

* Revert unnecessary change
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Fix next/prev tree-sitter inconsistency

Before there where different results going to next or previous due to
sorting not dealing with multiple captures that start/end at the same
pos. I chose to prefer longer matches.

* Revert unnecessary change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Rust, [c selects comment block, ]c only selects the first line of the comment block
3 participants