Switch MATLAB tree-sitter parser #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you run |
the-mikedavis
added
S-waiting-on-review
the-mikedavis
changed the title
|
Do you want me to change the commit message too? |
|
It's not necessary: since it's a single commit we will probably squash+merge which will rename the commit and include the PR number |
|
One question: do you update the tagged commit automatically or do I have to make pull-requests? |
|
It's done manually since grammar changes usually also require changes to the queries |
This was referenced Jun 23, 2023
Closed
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product of #7386.
I believe I got the highlight right, or at least now I get a nice rainbow-vomit when using the
doom_acario_darktheme. And no more quirks.Textobjects and indents were tested and are inline with what I found in other grammars. That is to say "could you please take a look at the indents because I think it is broken, but it is defined the same as other languages so I don't know if it's broken or if it's just me who doesn't know how this editor works".
I simply copied the other queries and did not adapt them or anything. I not even know if helix supports them.