Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to https://github.com/tree-sitter-perl/tree-sitter-perl #7644

Merged
merged 1 commit into from
Jul 17, 2023
Merged

switch to https://github.com/tree-sitter-perl/tree-sitter-perl #7644

merged 1 commit into from
Jul 17, 2023

Conversation

doy
Copy link
Contributor

@doy doy commented Jul 16, 2023 •
edited
Loading

fixes #7201

@pascalkuthe pascalkuthe added the S-waiting-on-review Status: Awaiting review from a maintainer. label Jul 16, 2023
the-mikedavis
the-mikedavis reviewed Jul 16, 2023
View reviewed changes
runtime/queries/perl/highlights.scm Show resolved Hide resolved
runtime/queries/perl/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/perl/injections.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Jul 16, 2023
@doy
Copy link
Contributor Author

doy commented Jul 16, 2023

how's this?

the-mikedavis
the-mikedavis reviewed Jul 16, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to run cargo xtask docgen and commit the changes to fix the CI

runtime/queries/perl/highlights.scm Outdated Show resolved Hide resolved
@doy
switch to https://github.com/tree-sitter-perl/tree-sitter-perl
98fc021 
it is not perfect, but it is much more accurate and up to date than the
previously used one.
@doy
Copy link
Contributor Author

doy commented Jul 16, 2023

looks like it's passing now!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2023
@archseer archseer merged commit e7f6061 into helix-editor:master Jul 17, 2023
@archseer
Copy link
Member

Hmm, this removed all the indentation queries though, so perl now doesn't support formatting anymore. I'll leave it for a follow-up

@doy doy mentioned this pull request Aug 15, 2023
Merged
@pascalkuthe pascalkuthe mentioned this pull request Apr 4, 2024
Closed
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@doy @mtoohey31
switch to https://github.com/tree-sitter-perl/tree-sitter-perl (helix…
d3a5edf 
…-editor#7644)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@doy
switch to https://github.com/tree-sitter-perl/tree-sitter-perl (helix…
a83f006 
…-editor#7644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perl grammar is old and unreliable
4 participants
@doy @archseer @the-mikedavis @pascalkuthe