feat: add todo.txt tree-sitter #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
languages.toml
Outdated
| [[language]] | ||
| name = "todotxt" | ||
| scope = "text.todotxt" | ||
| file-types = ["todo.txt", "todotxt"] |
There was a problem hiding this comment.
Suggested change
| file-types = ["todo.txt", "todotxt"] | |
| file-types = [".todo.txt"] |
This should work to catch .todo.txt files
There was a problem hiding this comment.
i tried it and test.todo.txt was not recognised.
as far as im aware this is not fixable without changing the recognition code since it checks the extension first (docs) and only checks other methods if it dosnt match (and .txt is the extension)
There was a problem hiding this comment.
Oh I see, I was thinking that .todo.txt was the full filename
There was a problem hiding this comment.
You could use suffix here, I think that should catch test.todo.txt:
file-types = [{ suffix = ".todo.txt"}, "todotxt"]There was a problem hiding this comment.
that worked. pushed a new commit
the-mikedavis
added
S-waiting-on-author
the-mikedavis
approved these changes
Aug 9, 2023
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Aug 9, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for todo.txt (docs, website).
Since i often use todo.txt for organizing and markdown is already included i wanted to offer upstreaming my config.
The official file extension is
.todo.txt, but that doesn't work with helix (and a bunch of other editors) due to the recognition prioritization, therefore i also added the alternative.todotxtextension.This uses the same tree-sitter as neovim.