Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(themes): material theme collection #8211

Merged
merged 11 commits into from
Sep 10, 2023
Merged

feat(themes): material theme collection #8211

merged 11 commits into from
Sep 10, 2023

Conversation

yhyadev
Copy link
Contributor

@yhyadev yhyadev commented Sep 8, 2023 •
edited
Loading

Preview

Material Deep Ocean

material_deep_ocean

Material Palenight

material_palenight

Material Darker

material_darker

Material Oceanic

material_oceanic

Inspired By

marco-cerovac/material.nvim
Material Theme Website

the-mikedavis
the-mikedavis reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be written as one theme and the others use theme inheritance? See the catppuccin themes for an example: https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_frappe.toml, https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_latte.toml, https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_mocha.toml

@yhyadev
Copy link
Contributor Author

yhyadev commented Sep 8, 2023 •
edited
Loading

Can this be written as one theme and the others use theme inheritance? See the catppuccin themes for an example: https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_frappe.toml, https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_latte.toml, https://github.com/helix-editor/helix/blob/master/runtime/themes/catppuccin_mocha.toml

Oh, Great idea i will try making "material-deep-ocean" the parent theme

@yhyadev
Copy link
Contributor Author

yhyadev commented Sep 8, 2023 •
edited
Loading

@the-mikedavis What about now?

@yhyadev yhyadev changed the title Add material theme collection feat(themes): material theme collection Sep 9, 2023
@yhyadev
Copy link
Contributor Author

yhyadev commented Sep 10, 2023 •
edited
Loading

Any requests other than that? @the-mikedavis

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Sep 10, 2023
@pascalkuthe pascalkuthe merged commit 6f3a657 into helix-editor:master Sep 10, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@yhyadev @dgkf
add material theme collection (helix-editor#8211)
c228d05 
* Create material theme files

* Add material deep ocean pallete

* Add primary theme properties to material deep ocean theme

* Fix material deep ocean theme

* Ad syntax highlighting to material deep ocean theme

* Make material oceanic theme

* Make material darker theme

* Remove material lighter theme

* Make material palenight theme

* Make other material themes inherit material deep ocean theme

* Add virtual ruler background to the material theme collection
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@yhyadev @mtoohey31
add material theme collection (helix-editor#8211)
fbee23f 
* Create material theme files

* Add material deep ocean pallete

* Add primary theme properties to material deep ocean theme

* Fix material deep ocean theme

* Ad syntax highlighting to material deep ocean theme

* Make material oceanic theme

* Make material darker theme

* Remove material lighter theme

* Make material palenight theme

* Make other material themes inherit material deep ocean theme

* Add virtual ruler background to the material theme collection
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@yhyadev
add material theme collection (helix-editor#8211)
8c2728c 
* Create material theme files

* Add material deep ocean pallete

* Add primary theme properties to material deep ocean theme

* Fix material deep ocean theme

* Ad syntax highlighting to material deep ocean theme

* Make material oceanic theme

* Make material darker theme

* Remove material lighter theme

* Make material palenight theme

* Make other material themes inherit material deep ocean theme

* Add virtual ruler background to the material theme collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhyadev @the-mikedavis @pascalkuthe