Allow specifying a different style for diff indicator in vcs gutter #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using a background in diff style (for nice patch file coloring) while keeping the gutter indicator nice (and using appropriate colors).
the-mikedavis
approved these changes
Sep 20, 2023
the-mikedavis
added
E-easy
pascalkuthe
approved these changes
Sep 20, 2023
danillos
pushed a commit
to danillos/helix
that referenced
this pull request
Nov 21, 2023
…elix-editor#8343) This allows using a background in diff style (for nice patch file coloring) while keeping the gutter indicator nice (and using appropriate colors).
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
…elix-editor#8343) This allows using a background in diff style (for nice patch file coloring) while keeping the gutter indicator nice (and using appropriate colors).
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…elix-editor#8343) This allows using a background in diff style (for nice patch file coloring) while keeping the gutter indicator nice (and using appropriate colors).
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…elix-editor#8343) This allows using a background in diff style (for nice patch file coloring) while keeping the gutter indicator nice (and using appropriate colors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
diff.plus/minus/deltakeys are used both for the gutter indicator and the syntax highlighting (for example in.patchfiles). This limits the abilities to theme the diffs nicely, as the background appear in the gutter line. For example, with existingpapercolor_lighttheme this gives:It is also hard to find a good color as the gutter indicator needs to be very colored as it has a very small surface, but it forces a very bright text.
This change allows using a different style for the gutter diff indicator, allowing things like:
with:
Making it a subkey allows maintaining compatibility with existing themes. Another option could be to add it to the
uikey with a fallback ondiff.