Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Bold/Italic/Strikethrough markdown in docs #8385

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Style Bold/Italic/Strikethrough markdown in docs #8385

merged 2 commits into from
Sep 25, 2023

Conversation

A-Walrus
Copy link
Contributor

Style doc comment markdown correctly with Bold / Strikethrough / Italics.
Before:
image

After:
image

Note the Italics of the word do

the-mikedavis
the-mikedavis previously approved these changes Sep 25, 2023
View reviewed changes
pascalkuthe
pascalkuthe reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine but I think the two nested match blocks are a bit hard to read. I think having one match arm for each recognized tag is fine (so simply text_style.add_modified(..) in each arm of the outer match)

@pascalkuthe pascalkuthe merged commit f520b16 into helix-editor:master Sep 25, 2023
6 checks passed
@A-Walrus A-Walrus deleted the ui_markdown_styles branch September 25, 2023 15:43
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
@A-Walrus @danillos
Style Bold/Italic/Strikethrough markdown in docs (helix-editor#8385)
6677ae9 
* Style Bold/Italic/Strikthrough markdown in docs

* Flatten to single match
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
@A-Walrus @dgkf
Style Bold/Italic/Strikethrough markdown in docs (helix-editor#8385)
843edaa 
* Style Bold/Italic/Strikthrough markdown in docs

* Flatten to single match
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@A-Walrus @mtoohey31
Style Bold/Italic/Strikethrough markdown in docs (helix-editor#8385)
ac07fd6 
* Style Bold/Italic/Strikthrough markdown in docs

* Flatten to single match
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@A-Walrus
Style Bold/Italic/Strikethrough markdown in docs (helix-editor#8385)
8cc0141 
* Style Bold/Italic/Strikthrough markdown in docs

* Flatten to single match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A-Walrus @the-mikedavis @pascalkuthe