Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add +N CLI argument to jump to first file's line number #8521

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

bjorn-ove
Copy link
Contributor

@bjorn-ove bjorn-ove commented Oct 11, 2023

Since the PR #5603 has not been updated, I went ahead and fixed the minor feedback from that PR and created a new one. I also fixed an issue making the first file never working with <file>:<line> as it was overridden.

Fixes #5437

@the-mikedavis the-mikedavis added C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 11, 2023
@the-mikedavis the-mikedavis changed the title Fix feedback for +num goto feature added in #5603 Add +N CLI argument to jump to first file's line number Oct 11, 2023
@pascalkuthe pascalkuthe merged commit 07a006d into helix-editor:master Oct 12, 2023
6 checks passed
@bjorn-ove bjorn-ove deleted the update-plus-goto-argument branch October 12, 2023 09:41
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
…#8521)

* Accept +num flag for opening at line number

* Update +N argument feature according to feedback in original PR helix-editor#5603

* Only override the line number of the first file if +N is specified

---------

Co-authored-by: Nachum Barcohen <[email protected]>
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
…#8521)

* Accept +num flag for opening at line number

* Update +N argument feature according to feedback in original PR helix-editor#5603

* Only override the line number of the first file if +N is specified

---------

Co-authored-by: Nachum Barcohen <[email protected]>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…#8521)

* Accept +num flag for opening at line number

* Update +N argument feature according to feedback in original PR helix-editor#5603

* Only override the line number of the first file if +N is specified

---------

Co-authored-by: Nachum Barcohen <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…#8521)

* Accept +num flag for opening at line number

* Update +N argument feature according to feedback in original PR helix-editor#5603

* Only override the line number of the first file if +N is specified

---------

Co-authored-by: Nachum Barcohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept +num flag for opening at line number
4 participants