Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: continue single-line comments #8664

Closed
wants to merge 23 commits into from
Closed

feat: continue single-line comments #8664

wants to merge 23 commits into from

Commits on Oct 20, 2023

  1. Add continue_comment function

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3844eb7 View commit details
    Browse the repository at this point in the history

  2. Add test for get_comment_token fn

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3d31e66 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect assertion

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    129ecae View commit details
    Browse the repository at this point in the history

  4. Wire up continue comment functionality

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2449622 View commit details
    Browse the repository at this point in the history

  5. Add comment-tokens field to languages.toml

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    036e2bf View commit details
    Browse the repository at this point in the history

  6. Add additional comment tokens for Rust

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    adda266 View commit details
    Browse the repository at this point in the history

  7. Match all comment-tokens fields with comment-token fields

    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    be9224e View commit details
    Browse the repository at this point in the history

  8. Refactor continue comment function to also return position of comment… 

    … token
    @seanchen1991
    seanchen1991 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e77d15d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Update calls to find_first_non_whitespace_char

    @seanchen1991
    seanchen1991 committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    751d15d View commit details
    Browse the repository at this point in the history

  2. Continue single comments with indentation

    @seanchen1991
    seanchen1991 committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    4315906 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Implement count_whitespace_after fn

    @seanchen1991
    seanchen1991 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0d224e5 View commit details
    Browse the repository at this point in the history

  2. Get tests for continue comment logic passing

    @seanchen1991
    seanchen1991 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ee9c015 View commit details
    Browse the repository at this point in the history

  3. Don't count newlines when counting whitespace

    @seanchen1991
    seanchen1991 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e44d55a View commit details
    Browse the repository at this point in the history

  4. Rename a variable

    @seanchen1991
    seanchen1991 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d816982 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Add continue-comment config parameter

    @seanchen1991
    seanchen1991 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e6a492b View commit details
    Browse the repository at this point in the history

  2. Contiue comments in insert mode based on config

    @seanchen1991
    seanchen1991 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c3a6190 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'helix-editor:master' into feature/continue-comment

    @seanchen1991
    seanchen1991 authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d25c959 View commit details
    Browse the repository at this point in the history

  2. Use pre-existing indentation functions to indent comment lines

    @seanchen1991
    seanchen1991 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    cbd05dc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/continue-comment' of https://github.com/seanche… 

    …n1991/helix into feature/continue-comment
    @seanchen1991
    seanchen1991 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d73cd87 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Clean up for PR submission

    @seanchen1991
    seanchen1991 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e170d40 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict in languages.toml

    @seanchen1991
    seanchen1991 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d52dae9 View commit details
    Browse the repository at this point in the history

  3. Remove changes in indent.rs

    @seanchen1991
    seanchen1991 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b03f870 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Remove incorrect unit test

    @seanchen1991
    seanchen1991 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    57261e5 View commit details
    Browse the repository at this point in the history