Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages: update rescript grammar #8962

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

nanzhong
Copy link
Contributor

@nanzhong nanzhong commented Dec 1, 2023

The currently pinned revision of the rescript grammar is failing to build with clang. jaredramirez/tree-sitter-rescript#2 has been merged, and addresses it in the referenced repo. This PR updates the pinned revision in languages.toml to reflect the fix.

This should also eventually allow the patch in nixpkgs (NixOS/nixpkgs#268191) to be cleaned up.

This bump fixes a build failure of the grammer with clang.
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pascalkuthe pascalkuthe merged commit 466b87c into helix-editor:master Dec 4, 2023
6 checks passed
@nanzhong nanzhong deleted the bump-rescript-grammar branch December 4, 2023 02:03
evanrichter pushed a commit to evanrichter/helix that referenced this pull request Dec 5, 2023
This bump fixes a build failure of the grammer with clang.
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Dec 11, 2023
This bump fixes a build failure of the grammer with clang.
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
This bump fixes a build failure of the grammer with clang.
nilium pushed a commit to nilium/helix that referenced this pull request Mar 10, 2024
This bump fixes a build failure of the grammer with clang.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
This bump fixes a build failure of the grammer with clang.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
This bump fixes a build failure of the grammer with clang.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
This bump fixes a build failure of the grammer with clang.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants