-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
languages: update rescript grammar #8962
Merged
pascalkuthe
merged 1 commit into
helix-editor:master
from
nanzhong:bump-rescript-grammar
Dec 4, 2023
Merged
languages: update rescript grammar #8962
pascalkuthe
merged 1 commit into
helix-editor:master
from
nanzhong:bump-rescript-grammar
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bump fixes a build failure of the grammer with clang.
dead10ck
approved these changes
Dec 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pascalkuthe
approved these changes
Dec 4, 2023
evanrichter
pushed a commit
to evanrichter/helix
that referenced
this pull request
Dec 5, 2023
This bump fixes a build failure of the grammer with clang.
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Dec 11, 2023
This bump fixes a build failure of the grammer with clang.
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
This bump fixes a build failure of the grammer with clang.
nilium
pushed a commit
to nilium/helix
that referenced
this pull request
Mar 10, 2024
This bump fixes a build failure of the grammer with clang.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
This bump fixes a build failure of the grammer with clang.
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
This bump fixes a build failure of the grammer with clang.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
This bump fixes a build failure of the grammer with clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently pinned revision of the rescript grammar is failing to build with clang. jaredramirez/tree-sitter-rescript#2 has been merged, and addresses it in the referenced repo. This PR updates the pinned revision in
languages.toml
to reflect the fix.This should also eventually allow the patch in nixpkgs (NixOS/nixpkgs#268191) to be cleaned up.