Check for rename support before showing LSP rename prompt #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we always showed the prompt even if the current document didn't have a language server that could perform a rename. For example we showed a rename prompt even when using `<space>r` in a scratch buffer. Instead we should check the document's language servers to see if any supports a rename and bail if there are none.
the-mikedavis
added
C-bug
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always showed the prompt even if the current document didn't have a language server that could perform a rename. For example we showed a rename prompt even when using
<space>rin a scratch buffer.Instead we should check the document's language servers to see if any supports a rename and bail if there are none.
This was originally #6249 (fixed in #6257) but regressed in #2507