-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse search functionality #958
Merged
archseer
merged 6 commits into
helix-editor:master
from
zingolabs:implement_reverse_search
Nov 6, 2021
Merged
Add reverse search functionality #958
archseer
merged 6 commits into
helix-editor:master
from
zingolabs:implement_reverse_search
Nov 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Nov 2, 2021
archseer
reviewed
Nov 2, 2021
archseer
reviewed
Nov 2, 2021
The note in I think it's okay to use a suboptimal implementation (forward search is really inefficient too since we have to turn the Rope into a String) and we'll replace it once |
archseer
reviewed
Nov 4, 2021
archseer
reviewed
Nov 4, 2021
archseer
reviewed
Nov 5, 2021
archseer
reviewed
Nov 5, 2021
archseer
approved these changes
Nov 6, 2021
Great work! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks a good deal less efficient than forward search, but searching a 1500+ line file for 'a' doesn't seem to have caused any noticeable latency for me.
I wasn't sure what to do with
extend_search_next
andextend_search_prev
, given that there's a shortage of letters left available, so I bound them toH
andL
.This is my first commit that's actually adding/renaming functions, let me know if there are any naming conventions I should be aware of.