Cleanup & warning fixes under MinGW64 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removal of whitespaces at the end of a line. - indentation (little bit) Fix for warnings under MinGW64: - the socket (DWORD) was compare to -1, should be vs INVALID_SOCKET - a few of the parameters of the pthread-wrapper weren't used, mark them as unused so there ain't no warnings. - SIGPIPEHandler was not used, and as it was a static, it spawned a warning about an unused function - return type for connectionHandlerThread was a NULL casted, should be a 0 - conversion from GetLastError to %d caused a warning. Now bring it first to a DWORD always to mitigate the warning.
|
One "big" todo here would be to interpret the WSAGetLastError better as the values are quite different between POSIX & Windows systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for warnings under MinGW64: