Add `changed_charts` and `chart_version` outputs #130

n-oden · 2023-01-24T15:48:13Z

This should let downstream steps make conditional decisions based on what we found.

Also: fix a confusing double-negative test in main().

Signed-off-by: Nathan J. Mehl [email protected]

n-oden · 2023-02-07T15:05:56Z

@cpanato ping? :)

n-oden · 2023-03-13T20:01:19Z

@davidkarlsen ping? :)

cpanato · 2023-03-14T09:44:06Z

I think this will require you to change the action.yml as well to make that explicitly the outputs

cpanato

see my comment

n-oden · 2023-03-14T19:37:25Z

@cpanato per the docs declaring outputs in action.yml is optional:

If you don't declare an output in your action metadata file, you can still set outputs and use them in a workflow.

That said if you'd prefer to have them explicitly declared I can definitely do that.

n-oden · 2023-03-23T14:00:12Z

@cpanato ping? :)

cpanato

thanks for this PR
I did some testing and this is not working

to make that work it will require some changes, see my coments

some test execution using your PR: https://github.com/cpanato/testing-ci-providers/actions/runs/4509916900/jobs/7940239844 check the echo step it does not output anything

a test execution using the requested changes: https://github.com/cpanato/testing-ci-providers/actions/runs/4510059253/jobs/7940556993

action.yml

cr.sh

n-oden · 2023-03-27T15:06:06Z

@cpanato thanks for the review! I've implemented your changes.

n-oden · 2023-04-15T18:15:14Z

@cpanato ping? :)

afernandez-01 · 2023-04-29T19:08:46Z

+1

cpanato · 2023-05-01T14:13:18Z

@n-oden testing is failing because in the CI we only install and do not run the full action, so the changed_charts.txt and the other file does not exist, we might want to add a safe guard to avoid that error

n-oden · 2023-05-02T15:52:12Z

@cpanato fixed; try again?

cr.sh

n-oden · 2023-05-15T15:22:02Z

@cpanato ping? :)

n-oden · 2023-06-02T15:31:39Z

@davidkarlsen @cpanato hey folks, any chance we can get this merged?

cpanato · 2023-07-06T08:26:54Z

@n-oden i will test this again

cpanato

need to add the missing id otherwise it will not know what to get the output

action.yml

This should let downstream steps make conditional decisions based on what we found. Also: fix a confusing double-negative test in main(). Signed-off-by: Nathan J. Mehl <[email protected]>

Signed-off-by: Nathan J. Mehl <[email protected]>

n-oden · 2023-07-10T21:17:31Z

@cpanato all done, take another look?

cpanato

lgtm
thanks!

* Add `changed_charts` and `chart_version` outputs This should let downstream steps make conditional decisions based on what we found. Also: fix a confusing double-negative test in main(). Signed-off-by: Nathan J. Mehl <[email protected]> --------- Signed-off-by: Nathan J. Mehl <[email protected]> Signed-off-by: Edmondo Porcu <[email protected]>

calvinrzachman · 2023-08-10T17:32:38Z

This is a great addition! Any chance we could cut a new release containing these changes?

pull-request-size bot added the size/S label Jan 24, 2023

cpanato requested a review from davidkarlsen February 10, 2023 08:44

cpanato requested changes Mar 14, 2023

View reviewed changes

n-oden force-pushed the main branch from cef7906 to 163744e Compare March 14, 2023 19:39

n-oden requested review from cpanato and removed request for davidkarlsen March 14, 2023 19:41

cpanato requested changes Mar 24, 2023

View reviewed changes

action.yml Show resolved Hide resolved

cr.sh Outdated Show resolved Hide resolved

cr.sh Outdated Show resolved Hide resolved

cr.sh Outdated Show resolved Hide resolved

n-oden force-pushed the main branch from e33e35b to 1254dba Compare March 27, 2023 15:05

n-oden requested a review from cpanato March 27, 2023 15:05

n-oden force-pushed the main branch from 1254dba to 2ac7316 Compare March 27, 2023 15:07

cpanato closed this May 1, 2023

cpanato reopened this May 1, 2023

n-oden force-pushed the main branch from 2ac7316 to d6c4441 Compare May 2, 2023 15:52

pull-request-size bot added size/L and removed size/S labels May 2, 2023

n-oden force-pushed the main branch from d6c4441 to 63aa072 Compare May 2, 2023 15:52

cpanato reviewed May 2, 2023

View reviewed changes

cr.sh Outdated Show resolved Hide resolved

n-oden force-pushed the main branch from 63aa072 to 7af8f49 Compare May 2, 2023 19:36

n-oden requested a review from cpanato May 2, 2023 19:36

cpanato closed this Jul 6, 2023

cpanato reopened this Jul 6, 2023

cpanato requested changes Jul 6, 2023

View reviewed changes

action.yml Show resolved Hide resolved

n-oden added 2 commits July 7, 2023 10:43

Add changed_charts and chart_version outputs

f1d2b5e

This should let downstream steps make conditional decisions based on what we found. Also: fix a confusing double-negative test in main(). Signed-off-by: Nathan J. Mehl <[email protected]>

address comments

104fd99

Signed-off-by: Nathan J. Mehl <[email protected]>

n-oden force-pushed the main branch from 7af8f49 to cdf98d9 Compare July 7, 2023 14:44

n-oden requested a review from cpanato July 7, 2023 14:44

add step id to release step

4c17026

Signed-off-by: Nathan J. Mehl <[email protected]>

n-oden force-pushed the main branch from cdf98d9 to 4c17026 Compare July 7, 2023 14:44

cpanato approved these changes Jul 11, 2023

View reviewed changes

cpanato merged commit 2504907 into helm:main Jul 11, 2023

calvinrzachman mentioned this pull request Aug 10, 2023

README example uses v1.6.0 but that doesn't exist #152

Open

IGx89 mentioned this pull request Nov 6, 2023

cr.sh: line 109: latest_tag: unbound variable #171

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `changed_charts` and `chart_version` outputs #130

Add `changed_charts` and `chart_version` outputs #130

n-oden commented Jan 24, 2023

n-oden commented Feb 7, 2023

n-oden commented Mar 13, 2023

cpanato commented Mar 14, 2023

cpanato left a comment

n-oden commented Mar 14, 2023

n-oden commented Mar 23, 2023

cpanato left a comment

n-oden commented Mar 27, 2023 •

edited

Loading

n-oden commented Apr 15, 2023

afernandez-01 commented Apr 29, 2023

cpanato commented May 1, 2023

n-oden commented May 2, 2023

n-oden commented May 15, 2023

n-oden commented Jun 2, 2023

cpanato commented Jul 6, 2023

cpanato left a comment

n-oden commented Jul 10, 2023

cpanato left a comment

calvinrzachman commented Aug 10, 2023

Add changed_charts and chart_version outputs #130

Add changed_charts and chart_version outputs #130

Conversation

n-oden commented Jan 24, 2023

n-oden commented Feb 7, 2023

n-oden commented Mar 13, 2023

cpanato commented Mar 14, 2023

cpanato left a comment

Choose a reason for hiding this comment

n-oden commented Mar 14, 2023

n-oden commented Mar 23, 2023

cpanato left a comment

Choose a reason for hiding this comment

n-oden commented Mar 27, 2023 • edited Loading

n-oden commented Apr 15, 2023

afernandez-01 commented Apr 29, 2023

cpanato commented May 1, 2023

n-oden commented May 2, 2023

n-oden commented May 15, 2023

n-oden commented Jun 2, 2023

cpanato commented Jul 6, 2023

cpanato left a comment

Choose a reason for hiding this comment

n-oden commented Jul 10, 2023

cpanato left a comment

Choose a reason for hiding this comment

calvinrzachman commented Aug 10, 2023

Add `changed_charts` and `chart_version` outputs #130

Add `changed_charts` and `chart_version` outputs #130

n-oden commented Mar 27, 2023 •

edited

Loading