Tag release with commit hash of the tip of current branch #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkwr
changed the title
At present, the tip of the default branch is tagged with the release. This is not ideal if we want to make releases out of non-default branches. Use the current commit ID as the input when invoking `cr upload` so that the releases are tagged correctly. Signed-off-by: Bharat Kunwar <[email protected]>
brtkwr
changed the title
|
Ping, anyone care to look at this? |
|
/cc @davidkarlsen |
davidkarlsen
approved these changes
Sep 22, 2020
|
Thanks for approving @davidkarlsen, when will this be incorporated into a release? |
|
@davidkarlsen when will this be merged? |
|
Merged, I believe @unguiculus has some more changes he wants in before a release. |
|
@davidkarlsen can we tag this release as v1.0.1 then tag @unguiculus's change as v1.0.2 when its ready? It would really help. Cheers. |
|
Sorry, I mixed the chart-testing and chart-releaser (helm/chart-testing#269). |
onkarganjewar
pushed a commit
to onkarganjewar/chart-releaser-action
that referenced
this pull request
Oct 13, 2020
At present, the tip of the default branch is tagged with the release. This is not ideal if we want to make releases out of non-default branches. Use the current commit ID as the input when invoking `cr upload` so that the releases are tagged correctly. Signed-off-by: Bharat Kunwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the tip of the default branch is tagged with the release instead of the branch target for release. This is not ideal if we want to make releases out of non-default branches. Use the current commit ID as the input when invoking
cr uploadso that the releases are tagged correctly.