Support actions triggered by a tag #96

luisico · 2021-10-12T18:16:15Z

helm/chart-releaser-action does not work on actions triggered by a tag because the lookup_changed_charts will never find differences in the charts. The problem is that lookup_latest_tag returns the tag that triggered the action, which is the current commit analyzed by lookup_changed_charts.

This simple solution skips the current (tagged) commit when searching for tags.

This is currently working for me. Others have requested it as well (#60).

Any feedback appreciated. Thanks

* Initialized `helm create` (version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.17.3"}) * Pointing probes to use the default nuts port and the `/status` endpoint * Modified the chart to point to the latest nuts image and setting the default internal port * Added the nuts config file as a mounted volume, so the config file is present inside the containers * Moved the original NUTS config to `values.yaml` and injecting it onto the nuts-configmap. * Added a PersistedVolume to persist the NUTS data in a mounted volume. * Embedding the certificates as a Secret into Kubhernetes. Also mounting the keys onto the filesystem. Enabling ssl to verify test the functionality. Also clarified the config path for the nuts data PV and made the nuts config file read-only. * Exposing post 5555 as a containerPort for gRPC traffic * Adding the base version of the chart README.md * Adding a link to the NUTS "Configuring for Production" documentation. * Adding installation information to the README. * Attempting to link to a specific header in the main README, doesn't work in local IDE but hoping it does in GitHub * Setting NUTS-specific values in the Chart.yaml. There are no NUTS versions yet, once this is present this will need to be set, and we can publish the releases to the NUTS Helm repo once added. * Removing unwanted character * Moved files from `./chart` to `./charts` to align with https://github.com/marketplace/actions/helm-chart-releaser defaults. * Building the `master` branch by default as `latest` is quite old * Attempting to build a Helm Chart on push / tag creation * Moving the chart data into the advised format of `./charts/<chart-name>/*` * Update Chart.yaml Upping the chart version. Testing if the CI pushes the new release * Removing the `CR_TOKEN` env as the repo is publicly available. Upping version to create a new helm chart * The `CR_TOKEN` env seems to be required by the plugin. Adding it back. * Changed the README Chart repo URLs with the expected endpoints when the PR is done. * Keeping the PV and PVC on the `helm uninstall` command as it can contain crucial data. * Attempting to skip helm package upload if tag exists * Update Chart.yaml Mimicking an appVersion update * Update Chart.yaml Mimicking another appVersion update, the previous version was pushed to the helm repo index.yaml already with the testing of a "tag" publish * Update Chart.yaml testing new chart push * Testing if the `gh-pages` branch for the push of new helm charts can be changed * Setting the "default" value in the `chart-releaser-action` config to clarify where it's pushed to * Chaging the ci to only trigger on pushes to the master branch. Removed the tags as this is already processed by a push to the master branch. * Only building on created version tags. Not "skipping" existing Helm charts as this'd be unexpected. * Adding the default property for the https://github.com/helm/chart-releaser-action#inputs action as we might want to change this in the future * Update Chart.yaml upping the version to test a CI build from a tag * Update Chart.yaml Mimicking release v1.16.5 * CI doesn't seem to find changes in chart, testing if the problem lies in adding the config property or with releasing via tags * Defaulting `enabletls: false` to align with nuts project defaults. Also upping the appVersion to see if this affects how chart version differences are calculated. * Reverting the chart push trigger to changes in the build. Apparently there are issues with building from tags (helm/chart-releaser-action#96). Adding this feature branch for testing purposes. Also added back the `CR_CHARTS_DIR` prop as it was unrelated to the bug in the CI action. Reverting the chart push trigger to changes in the build. Apparently there are issues with building from tags (helm/chart-releaser-action#96). Adding this feature branch for testing purposes. * Update Chart.yaml Upping version to test chart release via branch change instead of tag * Changing the version numbers to 0.0.1 so people know it's not a production-ready package. * Removing the feature branch as a CI action trigger * Extracting nuts-node and gRPC ports from the config file. Added information on these properties being "special" in the context of k8s. * Chaging default service http port to 1323 and changed the service to a multi-port service for gRPC Co-authored-by: Joris Scharp <[email protected]>

gbonnefille · 2022-03-18T15:47:07Z

Such change would be appreciated. For example to let prepare the Release by other actions, relying on new tag, like https://github.com/mindsers/changelog-reader-action

cpanato · 2022-09-27T07:45:21Z

@luisico thanks for the improvement, just to confirm using this the current behavior still works correct?

cpanato · 2022-09-27T07:45:50Z

can you please rebase when you have a chance? to get the latest from the branch

The original helm/chart-releaser-action does not work on actions triggered by a tag because the `lookup_changed_charts` will never find differences in the charts. The problem is that `lookup_latest_tag` returns the tag that triggered the action, which is the current commit analyzed by `lookup_changed_charts`. This simple solution skips the current (tagged) commit when searching for tags. Signed-off-by: Luis Gracia <[email protected]>

luisico · 2022-10-31T03:05:08Z

can you please rebase when you have a chance? to get the latest from the branch

Rebased, sorry for the delay.

luisico · 2022-10-31T03:08:42Z

@luisico thanks for the improvement, just to confirm using this the current behavior still works correct?

@cpanato I can't check the current behavior still works as I no longer main a project that uses this action, but based on your code changes, the behavior should be the same.

cpanato

did some tests and all good
thanks for that

edmondop · 2023-08-05T00:38:20Z

This is still not working for me

helm-bot added the size/XS label Oct 12, 2021

luisico force-pushed the on-tags branch from 3bdadf1 to 993fd72 Compare October 12, 2021 18:18

treydock mentioned this pull request Dec 1, 2021

Use Helm release action that works with tags postfinance/kubelet-csr-approver#3

Merged

JorisHeadease mentioned this pull request Feb 3, 2022

Feature/add helm chart nuts-foundation/nuts-node#800

Merged

harshaisgud mentioned this pull request Feb 24, 2022

Helm rel fix mondoohq/mondoo-operator#115

Merged

luisico force-pushed the on-tags branch from 993fd72 to 7c1e965 Compare October 31, 2022 03:03

cpanato requested review from cpanato and davidkarlsen November 23, 2022 12:09

cpanato approved these changes Mar 24, 2023

View reviewed changes

cpanato merged commit db5211e into helm:main Mar 24, 2023

cpanato mentioned this pull request Mar 24, 2023

Unable to release using tags #60

Closed

fabienduhamel added a commit to reezogit/aws-secrets-synchronizer that referenced this pull request May 31, 2023

fixed helm chart no changes helm/chart-releaser-action#96

b41a250

fabienduhamel added a commit to reezogit/aws-secrets-synchronizer that referenced this pull request May 31, 2023

fixed helm chart no changes helm/chart-releaser-action#96

da6588c

rgaiacs mentioned this pull request Jul 25, 2023

Support actions triggered by a tag not working #150

Open

eternalphane mentioned this pull request Nov 27, 2023

execute GH action release of helm chart only on new tag tektoncd/operator#1805

Merged

4 tasks

korenyoni mentioned this pull request Dec 7, 2023

cr.sh: line 109: latest_tag: unbound variable #171

Open

craftcodedev mentioned this pull request Apr 19, 2024

Worflow is not triggered by new tag #188

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support actions triggered by a tag #96

Support actions triggered by a tag #96

luisico commented Oct 12, 2021

gbonnefille commented Mar 18, 2022

cpanato commented Sep 27, 2022

cpanato commented Sep 27, 2022

luisico commented Oct 31, 2022

luisico commented Oct 31, 2022

cpanato left a comment

edmondop commented Aug 5, 2023

Support actions triggered by a tag #96

Support actions triggered by a tag #96

Conversation

luisico commented Oct 12, 2021

gbonnefille commented Mar 18, 2022

cpanato commented Sep 27, 2022

cpanato commented Sep 27, 2022

luisico commented Oct 31, 2022

luisico commented Oct 31, 2022

cpanato left a comment

Choose a reason for hiding this comment

edmondop commented Aug 5, 2023