[stable/rabbitmq] Option to create force_load file (#13485)

[denis111]

Signed-off-by: Denis Kalgushkin [email protected]

What this PR does / why we need it:

See #13485 . Adds an option to force rabbitmq start on unexpectedly shut down cluster.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes [stable/rabbitmq] Recover from "Waiting for Mnesia tables" after all nodes forced shutdown #13485

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: denis111
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

If they are not already assigned, you can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/rabbitmq/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @denis111. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[juan131]

Hi @denis111

It looks a very complex solution just for creating a "force_load" file.

To keep the chart as simple as possible, I'd suggest to implement a way to create that file during the container initialization when a certain env. variable is set (sth like RABBITMQ_FORCELOAD). What do you think about this approach?

[denis111]

Hi @juan131
Well yes, maybe it's too complex. I just saw how it's made for volume-permissions and also didn't want to touch volume-permisions init container.
Do you suggest to create the file in the main (not init) containter during the startup just before "exec rabbitmq-server"?

[juan131]

Do you suggest to create the file in the main (not init) containter during the startup just before "exec rabbitmq-server"?

Yes, I think that cant be a solution

[denis111]

@juan131
Ok, in that case I guess i can just use 'rabbitmqctl force_boot' command before exec. I hope to prepare a new PR next monday,

[denis111]

Created another PR #14149 so you can choose one and close another.

[juan131]

I'd rather follow the approach you used at #14149
Please close this PR since I don't have privileges to do so.