Add Stash chart #1420
Add Stash chart #1420
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @tamalsaha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-ok-to-test
| replicas: {{.Values.replicaCount}} | ||
| template: | ||
| metadata: | ||
| labels: |
There was a problem hiding this comment.
chart and heritage labels should be removed here.
stable/stash/templates/rbac.yaml
Outdated
| resources: | ||
| - pods | ||
| verbs: ["list", delete"] | ||
| --- |
| heritage: "{{ .Release.Service }}" | ||
| release: "{{ .Release.Name }}" | ||
| spec: | ||
| replicas: {{.Values.replicaCount}} |
There was a problem hiding this comment.
Add space after {{ and before }} and make sure it's consistent throughout the chart.
|
I have addressed your comments. |
|
Actually, I wanted you to fix the whitespace issue around braces in all files. Sorry, if this was not clear. |
|
Should be fixed now. It seems that the vscode extensions linting doed not identify this issue. PTAL. |
| @@ -0,0 +1,16 @@ | |||
| {{/* vim: set filetype=mustache: */}} | |||
There was a problem hiding this comment.
This is an outdated version of the file with wrong truncation. Update it from this example: https://github.com/kubernetes/helm/blob/master/docs/examples/nginx/templates/_helpers.tpl
|
Updated. PTAL. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
unguiculus
added
code reviewed
lgtm
* upstream/master: (67 commits) Fix json whitespace (helm#1458) Use consistent whitespace in template placeholders (helm#1437) [stable/selenium] Make hub readiness probe timeout configurable (helm#1391) [stable/kube2iam]: add rbac support (helm#1286) [stable/traefik] Allow enabling traefik access logs (helm#1302) Add Stash chart (helm#1420) Add Gearman G2 chart (helm#1421) add option to include tolerations to daemonset (helm#1364) Moved Artifactory to stable and updated version to 5.3.2 (helm#1314) Concourse postgres conditional dependency (helm#1390) Typo in helm install command for dask-distributed (helm#1413) [stable/fluent-bit] Fluent Bit v0.11.12 (helm#1417) fixed cassandra chart's persistence bug (helm#1245) Prometheus: modify config to support k8s 1.6 by default (helm#1080) Add rocket.chat (helm#752) Fix influxdb deployment (helm#1424) feat(stable/etcd-operator): add support for supplying additional command args (helm#1418) add configurable service annotations helm#1234 (helm#1244) [stable/prometheus] extra environment variable for alert manager (helm#1237) [stable/heapster] Default service name to Heapster (helm#1266) ...
Stash is a Kubernetes operator for restic. Using Stash, you can backup Kubernetes volumes mounted in following types of workloads:
Backed up files can be stored in various cloud storage provider, including S3, GCS, Azure, OpenStack Swift etc.