[stable/kuberhealthy] kuberhealthy 2.0.0 release chart with helm 3 #18899

integrii · 2019-11-15T01:39:05Z

This chart has been revamped to work with Helm 3 and our new upcoming release of Kuberhealthy 2.0.0.

Signed-off-by: Eric Greer [email protected]

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot · 2019-11-15T01:39:20Z

Hi @integrii. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

integrii · 2019-11-15T01:45:54Z

CircleCI says: Error: apiVersion 'v2' is not valid. The value must be "v1"

However, new charts created with Helm 3 using helm create come up with apiVersion'v2'. I am guessing this is an issue with the build system here?

integrii · 2019-11-15T01:49:58Z

Maybe @davidkarlsen can let us know if Helm3 charts are supported yet?

integrii · 2019-11-15T18:47:51Z

I am going to change the apiVersion back to v1 just to get this PR merged for now.

Signed-off-by: Eric Greer <[email protected]>

integrii · 2019-11-15T19:36:46Z

/lgtm

k8s-ci-robot · 2019-11-15T19:36:46Z

@integrii: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Eric Greer <[email protected]>

lolimjake · 2019-11-15T20:00:29Z

/lgtm

ihoegen · 2019-11-15T20:18:38Z

/ok-to-test

k8s-ci-robot · 2019-11-15T20:19:05Z

@ihoegen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ihoegen

/ok-to-test

k8s-ci-robot · 2019-11-15T20:19:53Z

@ihoegen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot · 2019-11-15T20:52:59Z

New changes are detected. LGTM label has been removed.

integrii · 2019-11-15T20:53:47Z

circle ci may have failed because of a botched cleanup?

I1115 20:02:47.651] Error: validation failed: unable to recognize "": no matches for kind "KuberhealthyCheck" in version "comcast.github.io/v1"

jonnydawg

/lgtm

k8s-ci-robot · 2019-11-15T20:56:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: integrii, jonnydawg, lolimjake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/kuberhealthy/OWNERS~~ [integrii,lolimjake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-11-15T20:56:57Z

@jonnydawg: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-15T22:29:40Z

@integrii: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

integrii · 2019-11-15T23:03:28Z

/test pull-charts-e2e

k8s-ci-robot · 2019-11-15T23:03:54Z

@integrii: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-charts-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jonnydawg · 2019-11-15T23:04:19Z

/ok-to-test

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot · 2019-11-15T23:04:46Z

@jonnydawg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidkarlsen · 2019-11-17T10:03:17Z

/ok-to-test

integrii · 2019-11-22T22:16:56Z

/test pull-charts-e2e

integrii · 2019-11-23T00:13:16Z

This CI run failed because the CRD was not recognized. This was probably not recognized because the tests are not using Helm 3, which recognizes the new crd directory as a set of specs that need ran first.

scottrigby

Re helm 3 charts, see this recent README update: https://github.com/helm/charts#status-of-the-project

Also some newline and extra line fixes needed.

stable/kuberhealthy/crds/khcheck.yaml

scottrigby · 2019-11-26T22:29:57Z

stable/kuberhealthy/templates/clusterrole.yaml

    - namespaces
    - componentstatuses
    - nodes
    verbs:
    - get
    - list
-    - watch
-
+    - watch


Needs one newline at EOF

scottrigby · 2019-11-26T22:30:50Z

stable/kuberhealthy/templates/clusterrolebinding.yaml

@@ -11,4 +11,4 @@ subjects:
 - kind: ServiceAccount
  name: {{ template "kuberhealthy.name" . }}
  namespace: {{ .Release.Namespace }}
-
+


Remove extra space on last line

scottrigby · 2019-11-26T22:31:17Z

stable/kuberhealthy/templates/khcheck-daemonset.yaml

+metadata:
+  name: daemonset-khcheck
+{{- end }}
+


Unnecessary extra line

scottrigby · 2019-11-26T22:31:58Z

stable/kuberhealthy/templates/khcheck-dns.yaml

+            cpu: 10m
+            memory: 50Mi
+{{- end }}
+


Unnecessary extra line

scottrigby · 2019-11-26T23:50:00Z

Also see #19008

scottrigby · 2019-11-26T23:50:42Z

/retest

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot · 2019-12-09T23:29:34Z

@integrii: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	`4317d39`	link	`/test pull-charts-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

davidkarlsen · 2020-01-07T01:07:08Z

Should this chart be deprecated in favour of https://github.com/Comcast/kuberhealthy/tree/master/deploy/helm/kuberhealthy ?
Maybe add the comcast repo to helm.hub: https://github.com/helm/hub/blob/master/Repositories.md ?

integrii · 2020-01-08T20:40:47Z

@davidkarlsen Good catch! That chart in the main Kuberhealthy project is basically this one. We run the script there in the same directory with it and contribute that as a chart here.

Now that helm 3 exists, I think having our own repository is much better - the release process here is hard! I will make an issue on Kuberhealthy for this now.

stale · 2020-02-08T00:44:38Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale · 2020-02-22T01:00:52Z

This issue is being automatically closed due to inactivity.

kuberhealthy 2.0.0 release chart with helm 3

00b75de

Signed-off-by: Eric Greer <[email protected]>

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2019

integrii mentioned this pull request Nov 15, 2019

Create helm chart for Kuberhealthy 2 kuberhealthy/kuberhealthy#111

Closed

3 tasks

dropping apiVersion back to v1 for charts circleci

9338aa7

Signed-off-by: Eric Greer <[email protected]>

helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 15, 2019

disable pod restarts and status checks by default

4f79cad

Signed-off-by: Eric Greer <[email protected]>

integrii force-pushed the master branch from 63d7c13 to 4f79cad Compare November 15, 2019 19:45

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 15, 2019

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019

ihoegen approved these changes Nov 15, 2019

View reviewed changes

more owners

3430f8b

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019

jonnydawg approved these changes Nov 15, 2019

View reviewed changes

deployment 1.0.2

c0d7167

Signed-off-by: Eric Greer <[email protected]>

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2019

scottrigby reviewed Nov 26, 2019

View reviewed changes

helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 9, 2019

newline fixes and upping check versions

9448ebb

Signed-off-by: Eric Greer <[email protected]>

integrii force-pushed the master branch from c6cdf3a to 9448ebb Compare December 9, 2019 18:59

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Dec 9, 2019

add namespace

4317d39

Signed-off-by: Eric Greer <[email protected]>

integrii force-pushed the master branch from 9eeadad to 4317d39 Compare December 9, 2019 23:27

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 9, 2019

integrii mentioned this pull request Jan 8, 2020

Publish Kuberhealthy as a Helm Repository kuberhealthy/kuberhealthy#288

Closed

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2020

stale bot closed this Feb 22, 2020

[stable/kuberhealthy] kuberhealthy 2.0.0 release chart with helm 3 #18899

[stable/kuberhealthy] kuberhealthy 2.0.0 release chart with helm 3 #18899

Conversation

integrii commented Nov 15, 2019

Checklist

k8s-ci-robot commented Nov 15, 2019

integrii commented Nov 15, 2019

integrii commented Nov 15, 2019

integrii commented Nov 15, 2019

integrii commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

lolimjake commented Nov 15, 2019

ihoegen commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

ihoegen left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

integrii commented Nov 15, 2019

jonnydawg left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

integrii commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

jonnydawg commented Nov 15, 2019

k8s-ci-robot commented Nov 15, 2019

davidkarlsen commented Nov 17, 2019

integrii commented Nov 22, 2019

integrii commented Nov 23, 2019

scottrigby left a comment

Choose a reason for hiding this comment

scottrigby Nov 26, 2019

Choose a reason for hiding this comment

scottrigby Nov 26, 2019

Choose a reason for hiding this comment

scottrigby Nov 26, 2019

Choose a reason for hiding this comment

scottrigby Nov 26, 2019

Choose a reason for hiding this comment

scottrigby commented Nov 26, 2019

scottrigby commented Nov 26, 2019

k8s-ci-robot commented Dec 9, 2019

davidkarlsen commented Jan 7, 2020

integrii commented Jan 8, 2020

stale bot commented Feb 8, 2020

stale bot commented Feb 22, 2020