Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/contour] fix replica count conflict #19202

Merged
merged 1 commit into from
Dec 1, 2019
Merged

[stable/contour] fix replica count conflict #19202

merged 1 commit into from
Dec 1, 2019

Conversation

naseemkullah
Copy link
Collaborator

Signed-off-by: Naseem [email protected]

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

cc @scottrigby
affects helm3 managed releases.
Please see #19008 for more info

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2019
@poidag-zz
Copy link
Collaborator

Hi, @naseemkullah Thanks for the PR!

Are you able to create an issue and provide a little context into the problem and make a reference as a comment here?

@naseemkullah
Copy link
Collaborator Author

Hi @pickledrick, no problem, sure:

Helm 3's 3-way strategic merge strategy is a huge improvement, and is the correct way to go. However it uncovered that one use case for the incorrect behavior in Helm 2 actually had a nice outcome: HPA-scaled replicas were untouched on helm upgrade, whereas Helm 3 now sets the replicas back to the values/template-defined number of replicas.

@scottrigby scottrigby mentioned this pull request Nov 28, 2019
Closed
18 tasks
poidag-zz
poidag-zz approved these changes Nov 29, 2019
View reviewed changes
Copy link
Collaborator

@poidag-zz poidag-zz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: naseemkullah, pickledrick, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 86316ca into helm:master Dec 1, 2019
@naseemkullah naseemkullah deleted the contour-replicas-conflict branch December 1, 2019 21:49
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@naseemkullah
fix replica count conflict (helm#19202)
a2bed45 
Signed-off-by: Naseem <[email protected]>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@naseemkullah @dargolith
fix replica count conflict (helm#19202)
744a8a5 
Signed-off-by: Naseem <[email protected]>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@naseemkullah
fix replica count conflict (helm#19202)
1094cfa 
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Artur <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@poidag-zz poidag-zz poidag-zz approved these changes

@boluisa boluisa Awaiting requested review from boluisa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naseemkullah @poidag-zz @scottrigby @k8s-ci-robot @helm-bot