This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/sparkoperator] Introduce crds directory for compatibility with Helm v3 #19236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Helm v3 Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
helm-bot
added
Contribution Allowed
18 tasks
scottrigby
suggested changes
Dec 1, 2019
Signed-off-by: Xiang Dai <[email protected]>
scottrigby
suggested changes
Dec 2, 2019
Signed-off-by: Xiang Dai <[email protected]>
liyinan926
reviewed
Dec 9, 2019
Signed-off-by: Xiang Dai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daixiang0, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
…with Helm v3 (helm#19236) * [incubator/sparkoperator] Introduce crds directory for compatibility with Helm v3 Signed-off-by: Xiang Dai <[email protected]> * remove cleanupCrdsBeforeInstall Signed-off-by: Xiang Dai <[email protected]> * feedback Signed-off-by: Xiang Dai <[email protected]> * add note Signed-off-by: Xiang Dai <[email protected]> * fix nits Signed-off-by: Xiang Dai <[email protected]>
arturrez
pushed a commit
to arturrez/stable-charts
that referenced
this pull request
Jan 28, 2020
…with Helm v3 (helm#19236) * [incubator/sparkoperator] Introduce crds directory for compatibility with Helm v3 Signed-off-by: Xiang Dai <[email protected]> * remove cleanupCrdsBeforeInstall Signed-off-by: Xiang Dai <[email protected]> * feedback Signed-off-by: Xiang Dai <[email protected]> * add note Signed-off-by: Xiang Dai <[email protected]> * fix nits Signed-off-by: Xiang Dai <[email protected]> Signed-off-by: Artur <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiang Dai [email protected]
What this PR does / why we need it:
support helm v3.
Which issue this PR fixes
Related to Issue #19008
Special notes for your reviewer:
This is not a complete migration to Helm v3. This PR make the Chart installable with Helm 3.
This PR remove
cleanupCrdsBeforeInstalloption and set installCrds asfalseas default.Checklist
DCO signed
Chart Version bumped