Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kong] Add check for config changes #20051

Merged
merged 1 commit into from
Jan 10, 2020
Merged

[stable/kong] Add check for config changes #20051

merged 1 commit into from
Jan 10, 2020

Conversation

krish7919
Copy link
Contributor

Add an admission webhook config checksum as an annotation in the
Deployment so that the pods can be redeployed by K8s when the config
changes during redeployments.

Is this a new chart

No

What this PR does / why we need it:

Bugfix

Which issue this PR fixes

Special notes for your reviewer:

Tested on my local setup. It redeploys the pod containing the kong and ingress-controller containers which then uses the new certificates in the Secret successfully.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @krish7919. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krish7919 krish7919 force-pushed the 20050-checksum-check-admission-controller branch from 69609fd to 19a63d7 Compare January 10, 2020 20:21
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2020
[stable/kong] Add check for config changes
59981f7 
- Add an admission webhook config checksum as an annotation in the
Deployment so that the pods can be redeployed by K8s when the config
changes during redeployments

Signed-off-by: Krish <[email protected]>
@krish7919 krish7919 force-pushed the 20050-checksum-check-admission-controller branch from 19a63d7 to 59981f7 Compare January 10, 2020 20:23
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 10, 2020
hbagdi
hbagdi approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, krish7919

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9dc5cfa into helm:master Jan 10, 2020
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@krish7919 @k8s-ci-robot
[stable/kong] Add check for config changes (helm#20051)
790b209 
- Add an admission webhook config checksum as an annotation in the
Deployment so that the pods can be redeployed by K8s when the config
changes during redeployments

Signed-off-by: Krish <[email protected]>
Signed-off-by: Artur <[email protected]>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@krish7919
[stable/kong] Add check for config changes (helm#20051)
4cce808 
- Add an admission webhook config checksum as an annotation in the
Deployment so that the pods can be redeployed by K8s when the config
changes during redeployments

Signed-off-by: Krish <[email protected]>
Signed-off-by: Artur <[email protected]>
@rainest rainest mentioned this pull request Feb 4, 2021
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hbagdi hbagdi hbagdi approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/kong] Ingress Controller errors when chart is redeployed with Admission Webhook enabled
4 participants
@krish7919 @k8s-ci-robot @hbagdi @helm-bot