-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/prometheus-operator] Added more options for AlertManager ServiceMonitoring #23402
[stable/prometheus-operator] Added more options for AlertManager ServiceMonitoring #23402
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pburgisser-c2c The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pburgisser-c2c. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Philippe Bürgisser <[email protected]>
50180c1
to
b8f3c13
Compare
/assign @vsliouniaev @bismarck |
/ok-to-test |
@pburgisser-c2c: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @scottrigby, You helped on my PR #22725 to merge the conflict to the test could run. Is there a way to avoid such issue in the future? Thanks! |
/hold Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great! Regarding CI failures here, it’s an ongoing issue with potentially different causes. The new Helm GitHub Actions CI will go a long way to help because each chart change is tested in complete isolation, unlike the current CI which shares a test cluster (where various conflicts can happen, depending which tests are currently running). For this chart, let’s try to focus on getting the new repo in prometheus-community set up? It seems we are close now. |
@pburgisser-c2c as a user and contributor, would you mind helping to review/test this PR? prometheus-community/helm-charts#1 No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Also @bismarck. Thanks! |
🚧 This chart is now deprecated. Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the If applicable, please re-open this PR there. Thanks! |
Signed-off-by: Philippe Bürgisser (Camptocamp) [email protected]
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)