Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Added more options for AlertManager ServiceMonitoring #23402

Conversation

pburgisser
Copy link
Contributor

Signed-off-by: Philippe Bürgisser (Camptocamp) [email protected]

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pburgisser-c2c
To complete the pull request process, please assign bismarck
You can assign the PR to them by writing /assign @bismarck in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @pburgisser-c2c. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2020
@pburgisser pburgisser force-pushed the add_alertmanager_servicemonitor_config branch from 50180c1 to b8f3c13 Compare July 30, 2020 14:35
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 30, 2020
@pburgisser
Copy link
Contributor Author

/assign @vsliouniaev @bismarck

@bismarck
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2020
@k8s-ci-robot
Copy link
Contributor

@pburgisser-c2c: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e b8f3c13 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pburgisser
Copy link
Contributor Author

Hi @scottrigby,

You helped on my PR #22725 to merge the conflict to the test could run.
I see there is still an issue with testing with this current PR. Can you help please?$

Is there a way to avoid such issue in the future?

Thanks!
cc: @bismarck

@scottrigby
Copy link
Member

/hold

Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!

Regarding CI failures here, it’s an ongoing issue with potentially different causes. The new Helm GitHub Actions CI will go a long way to help because each chart change is tested in complete isolation, unlike the current CI which shares a test cluster (where various conflicts can happen, depending which tests are currently running).

For this chart, let’s try to focus on getting the new repo in prometheus-community set up? It seems we are close now.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@scottrigby
Copy link
Member

@pburgisser-c2c as a user and contributor, would you mind helping to review/test this PR? prometheus-community/helm-charts#1

No need to reply here. If you can, please just reply and help there. It would help this process move along faster.

Also @bismarck. Thanks!

@scottrigby
Copy link
Member

🚧 This chart is now deprecated.

Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.

If applicable, please re-open this PR there. Thanks!

@scottrigby scottrigby closed this Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants