-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[prometheus-operator] fixed hardcoded label for grafana servicemonitor #23516
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Morriz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Morriz. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gianrubio |
Signed-off-by: [email protected] |
Signed-off-by: Maurice Faber <[email protected]>
Signed-off-by: Maurice Faber <[email protected]>
/hold Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great! |
@Morriz as a user/contributor, would you mind helping to review and test this PR? prometheus-community/helm-charts#1 No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Thanks! |
@scottrigby I am replying here though, as I am still not a maintainer, and can't add myself as reviewer yet. But I would like to! |
@Morriz hi 👋 I created this issue to discuss adding additional chart maintainers for the new repo. This will have to be a conversation with current maintainers and prom devs. prometheus-community/helm-charts#21 PS, Generally what is good to see before adding a user as a maintainer of a chart is a history of contribution, willingness to read best practice guides, and be generally helpful witha chart (including help testing and reviewing other pull requests), etc. Hope that helps 🙂 |
@Morriz another thing that would be very helpful at this point is testing this PR: prometheus-community/helm-charts#1 See these comments:
User testing is not required but it will help give higher confidence that everything has been addressed properly in the renaming PR. |
🚧 This chart is now deprecated. Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the If applicable, please re-open this PR there. Thanks! |
Now each grafana instance can have it's own servicemonitor. Fixes #23513