Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[prometheus-operator] fixed hardcoded label for grafana servicemonitor #23516

Closed
wants to merge 2 commits into from
Closed

Conversation

Morriz
Copy link
Contributor

@Morriz Morriz commented Aug 12, 2020

Now each grafana instance can have it's own servicemonitor. Fixes #23513

  • DCO signed
  • Chart Version bumped

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Morriz
To complete the pull request process, please assign gianrubio
You can assign the PR to them by writing /assign @gianrubio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Morriz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Morriz Morriz changed the title fixed hardcoded label for grafana servicemonitor [prometheus-operator] fixed hardcoded label for grafana servicemonitor Aug 12, 2020
@Morriz
Copy link
Contributor Author

Morriz commented Aug 12, 2020

/assign @gianrubio

@Morriz
Copy link
Contributor Author

Morriz commented Aug 12, 2020

Signed-off-by: [email protected]

Signed-off-by: Maurice Faber <[email protected]>
Signed-off-by: Maurice Faber <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 12, 2020
@scottrigby
Copy link
Member

/hold

Let’s hold PRs to prometheus-operator for a short time until prometheus-community/community#28 (comment) is resolved. If you want to help with that effort, to test etc, that would be great!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@scottrigby
Copy link
Member

@Morriz as a user/contributor, would you mind helping to review and test this PR? prometheus-community/helm-charts#1

No need to reply here. If you can, please just reply and help there. It would help this process move along faster. Thanks!

@Morriz
Copy link
Contributor Author

Morriz commented Aug 24, 2020

@scottrigby I am replying here though, as I am still not a maintainer, and can't add myself as reviewer yet. But I would like to!

@scottrigby
Copy link
Member

@Morriz hi 👋 I created this issue to discuss adding additional chart maintainers for the new repo. This will have to be a conversation with current maintainers and prom devs.

prometheus-community/helm-charts#21

PS, Generally what is good to see before adding a user as a maintainer of a chart is a history of contribution, willingness to read best practice guides, and be generally helpful witha chart (including help testing and reviewing other pull requests), etc. Hope that helps 🙂

@scottrigby
Copy link
Member

@Morriz another thing that would be very helpful at this point is testing this PR: prometheus-community/helm-charts#1

See these comments:

User testing is not required but it will help give higher confidence that everything has been addressed properly in the renaming PR.

@scottrigby
Copy link
Member

🚧 This chart is now deprecated.

Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.

If applicable, please re-open this PR there. Thanks!

@scottrigby scottrigby closed this Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-operator] grafana servicemonitor label is hardcoded to "grafana"
5 participants