WIP: [stable/traefik] Keep basic auth user/passwd data in secret

[krancour]

@c-knowles you will be interested in this, I think. It's the follow-up to #414

This depends on traefik/traefik#1189 being merged and included in a future Traefik release.

@c-knowles if you want to test drive, the Docker image krancour/traefik:usersfile is built from my fork of Traefik.

[k8s-ci-robot]

Hi @krancour. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cknowles]

Great! Let's hope they merge that in soon. I wonder if we could cut down on some of the conditionals and always create the secret but with empty users if non are defined? We could always mount the secret too which keeps deployment.yaml simpler.

[cknowles]

Does this need to be wrapped in {{- if .Values.dashboard.auth }}?

[krancour]

Not really. The only thing that calls this is wrapped in those conditionals already and I don't foresee this being reused in this chart. (I didn't do it this way for the sake of reuse... this "sub-template" was the only way I could think of, at the time, to build a string by ranging over an array, and then get that string into a pipeline so I can base64 encode it... but I think I've thought of a more straightforward way to do that now, so I'll be updating this on Monday.)

[lachie83]

@c-knowles What's the latest on this?

[cknowles]

It looks like @krancour's PR above has been merged so I hope they include that with 1.2.0 GA. Otherwise the change looks good to me.

[lachie83]

@c-knowles do we need to wait for that release for these changes to work?

[cknowles]

@lachie83 I don't think @krancour's changes here would break anything existing but yep we'll have to wait for that next Traefik release for this to work.

[krancour]

I have some modifications I want to make to this chart still. I don't have a real sense of urgency about it because, as noted by @c-knowles I'm waiting for my PR to Traefik to make it into a GA release.

[lachie83]

@krancour @c-knowles shall we close this for now?

[krancour]

@lachie83 depends how much it bothers you to leave it open. Personally, for me, it's better to leave it open because then it doesn't fall off my own radar. Up to you tho.

[prydonius]

@krancour just checking in, we still waiting for an upstream release here?

[prydonius]

@krancour ping

[viglesiasce]

Closing as this has now been marked stale for 17 days:

https://github.com/kubernetes/charts#stale-pull-requests

[krancour]

I'll have another look at this. I'm sure the feature I contributed to Traefik (which this chart depends on) must be included in 1.3.x. Not sure when I will get to this though.