-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add docsearch #194
Feat/add docsearch #194
Conversation
ce84b26
to
2700a73
Compare
Sylvian this is perfect! 🎉🎉🎉 Thank you for integrating this. Happy to 👍 this PR |
4db99a4
to
4d40c27
Compare
Signed-off-by: s-pace <[email protected]>
Signed-off-by: s-pace <[email protected]>
Signed-off-by: s-pace <[email protected]>
4d40c27
to
22493a3
Compare
@flynnduism thank you for the feedback 🙏. I have just cleaned up the noise introduced by the PR. Feel free to ping me if you need anything before merging it. |
Hi @s-pace! Thank you for working on this and showing us docsearch. Very neat piece of tech 👍 I had a question about the billing model. By merging this PR, are we subject to the pricing models displayed on the site? Is this service free for open source projects like Helm, or are we subject to the same billing model as others? How does that work? Thanks! |
Hi @bacongobbler, Thank you for your feedback 🎉. DocSearch is entirely free for open source project :). Helm does qualify in its entirety. It is our way to give back to the community. If you want to have access to the analytics we provide for your DocSeach index ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checked out https://docsearch-helm.surge.sh/docs/ and it looks good. Also checked out the local preview: https://deploy-preview-194--helm-merge.netlify.com/docs/ - LGTM. |
@bridgetkromhout Thank you for the feedback 🙏 @bacongobbler Let us know if you need anything to make this happen 🔍 |
👋 Hello team,
Following helm/helm#4679, this PR add a search experience to the docs.
I'm part of the project called DocSearch which goal is to enhance documentation websites with exhaustive, fast and relevant search. You might have seen DocSearch live already on websites like Bootstrap, Reactjs or Gulp.
I have created a quick demo of what DocSearch enables on your documentation thanks to this PR. You can try it out here.
Happy to update the PR if needed.
Resolves #56