Change MPI buffer creation + 1D non-contiguous tensors #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock for 1D non-contiguous tensors in comm.mpi_type_and_elements_of()
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 90.84% 90.85% +0.01%
==========================================
Files 64 64
Lines 8921 8932 +11
==========================================
+ Hits 8104 8115 +11
Misses 817 817
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…s tensors to make sure that the memory is handled correctly
…ad of only in-place function
|
verbal approval received from @Markus-Goetz for merge. waiting for tests, then this will be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
storage_offsetwhen finding the mpi buffer (communication. MPICommunication.as_mpi_memory()).Added allowance for 1 dimensional non-contiguous local tensors in
communication. MPICommunication.mpi_type_and_elements_of()Issue/s resolved: #769 #784
Changes proposed:
storage_offsetaddition to data pointer incommunication. MPICommunication.as_mpi_memory()communication. MPICommunication.mpi_type_and_elements_of()Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no