Fix of the compare function #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the compare function was not consistent (it did not follow the requirements on the compare function), see https://tc39.github.io/ecma262/#sec-array.prototype.sort for details. You can see that the compare function is not correct by using it to sort larger arrays. For example, if you sort the letters of a well known sentence: `"the quick brown fox jumps over the lazy dog".split('').sort((a,b) => a>b).join('')` returns `"uge d ac be e f otjhmpsnooqrothrkliuvwxyz"` on Node.js 6.7.0. While `"the quick brown fox jumps over the lazy dog".split('').sort((a,b) => a > b ? 1 : (a < b ? -1 : 0)).join('')` returns the correct result `' abcdeeefghhijklmnoooopqrrsttuuvwxyz'`.
|
Thanks I'm surprised I didn't catch that. I have other sorting libs that do this. thanks for the fix. |
|
Thanks for your fast response!
It is funny that you have mentioned that. I have a similar PR waiting for a merge jonschlinkert/array-sort#4 in that repository as well ;-). |
|
ha, well I might as well give up on sorting lol. Thanks, and sorry it has taken so long to get back to that issue. I'll try to get these merged and published today. I really appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the compare function was not consistent (it did not follow the requirements on the compare function), see https://tc39.github.io/ecma262/#sec-array.prototype.sort for details. You can see that the compare function is not correct by using it to sort larger arrays. For example, if you sort the letters of a well known sentence:
"the quick brown fox jumps over the lazy dog".split('').sort((a,b) => a>b).join('')returns
"uge d ac be e f otjhmpsnooqrothrkliuvwxyz"on Node.js 6.7.0. While"the quick brown fox jumps over the lazy dog".split('').sort((a,b) => a > b ? 1 : (a < b ? -1 : 0)).join('')returns the correct result' abcdeeefghhijklmnoooopqrrsttuuvwxyz'.