Make ccache-action respect environment variables #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This seems fine to me, let's just run the tests. |
|
@TrentHouliston can you look into the errors? Seems easy to fix. |
|
@krlmlr WDYT? Does this solve your use case? |
|
Regardless of #165 this change is ready and makes sense. Thanks for the contribution @TrentHouliston ! |
|
@hendrikmuhs A release would be good so I don't have to keep using my fork |
|
Thanks. I'll review and get back here if problems arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if environment variables are set for CCACHE_DIR or SCCACHE_DIR then this action will ignore them and hardcode its own.
This is a problem if CCACHE_DIR is set for example in a docker file environment which is very hard to eliminate
Fixes #96
I think this is a better solution than #165 as that one still suffers from an invalid operation if either of the environment variables are set.