Skip to content

Commit

Permalink
Frozen autoscaling should not use local storage
Browse files Browse the repository at this point in the history
The reactive decider no longer applies to the frozen tier, since it
could grossly over-estimate the amount of storage for unassigned frozen
shards.

Relates elastic#71042
  • Loading branch information
henningandersen committed Apr 11, 2021
1 parent c7792d6 commit 0d62596
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public void testScaleFromEmptyLegacy() {
}

/**
* Verify that the list of roles includes all data roles to ensure we consider adding future data roles.
* Verify that the list of roles includes all data roles except frozen to ensure we consider adding future data roles.
*/
public void testRoles() {
// this has to be an integration test to ensure roles are available.
Expand All @@ -204,7 +204,9 @@ public void testRoles() {
assertThat(
service.roles().stream().sorted().collect(Collectors.toList()),
Matchers.equalTo(
DiscoveryNode.getPossibleRoles().stream().filter(DiscoveryNodeRole::canContainData).sorted().collect(Collectors.toList())
DiscoveryNode.getPossibleRoles().stream().filter(DiscoveryNodeRole::canContainData)
.filter(r -> r != DiscoveryNodeRole.DATA_FROZEN_NODE_ROLE)
.sorted().collect(Collectors.toList())
)
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@ public List<DiscoveryNodeRole> roles() {
DiscoveryNodeRole.DATA_CONTENT_NODE_ROLE,
DiscoveryNodeRole.DATA_HOT_NODE_ROLE,
DiscoveryNodeRole.DATA_WARM_NODE_ROLE,
DiscoveryNodeRole.DATA_COLD_NODE_ROLE,
DiscoveryNodeRole.DATA_FROZEN_NODE_ROLE
DiscoveryNodeRole.DATA_COLD_NODE_ROLE
);
}

Expand Down

0 comments on commit 0d62596

Please sign in to comment.