fix: Resolve Attribute issue causing Android Build to fail #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line resolving the 'dialogPreferredPadding' attribute to include the 'android' prefix. This change corrects an error where the attribute could not be found, causing the build to fail on Android.
riddy6421
reviewed
Aug 31, 2024
| @@ -171,7 +171,7 @@ public AlertDialogBuilder setColoredTitle(ReadableMap props){ | |||
| coloredTitle.setText(title); | |||
| TypedValue typedValue = new TypedValue(); | |||
| Resources.Theme theme = DatePickerPackage.context.getCurrentActivity().getTheme(); | |||
| theme.resolveAttribute(R.attr.dialogPreferredPadding, typedValue, true); | |||
| theme.resolveAttribute(android.R.attr.dialogPreferredPadding, typedValue, true); | |||
There was a problem hiding this comment.
Can verify this fix work! Thanks @lil-sahil
|
@lil-sahil Thanks for your contribution! Do you know if there are still scenarios where this attribute won’t be found? (Considering if we need to add default values for the padding) |
henninghall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fix resolveAttribute issue in DatePickerModuleImpl.java
Updated the line resolving the 'dialogPreferredPadding' attribute to include the 'android' prefix. This change corrects an error where the attribute could not be found, causing the build to fail on Android.
Previous:
theme.resolveAttribute(R.attr.dialogPreferredPadding, typedValue, true);
Updated:
theme.resolveAttribute(android.R.attr.dialogPreferredPadding, typedValue, true);
This fix ensures that the correct system attribute is referenced, preventing the build failure."