Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Optional_Files #55

Open
wants to merge 6 commits into
base: develop_aws
Choose a base branch
from

Conversation

geertvandeweyer
Copy link
Collaborator

As raised by Peter Thomas on slack :

Added support for optional files in the AWS handling of (de)localization and caching:

  • support for "File?"
  • support for "Array[File?] in manual assignment
  • support for "Array[File?]" in globbing

Tested for input and output of individual tasks and workflows:

  • optional files are allowed to be missing during (de)localization on both S3 and EFS (mentioned to log)
  • optional files are considered valid in cache-hash calculation (if missing in original, and still missing => valid hit) (silent)

extra : minor optimization on hashing through EFS/MD5 files : if considered invalid, return a random string instead of the same message each time. This forces a cache-break.

Note: Mixed types are not supported and cast to mandatory files:

  • an array of [File_1, File_2] where _1 is optional and _2 is not, will be "non-optional" completely.

For testing : see release 87.1-AWS in my own fork : https://github.com/geertvandeweyer/cromwell/releases/tag/87.1-AWS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant