TaskTLS: Rework creation

src/arch/aarch64/kernel/scheduler.rs

@@ -207,7 +207,7 @@ pub struct TaskTLS {
 }
 
 impl TaskTLS {
-	pub fn new(tls_size: usize) -> Self {
+	fn from_environment() -> Self {
 		Self {
 			address: VirtAddr::zero(),
 		}
@@ -229,7 +229,7 @@ impl Drop for TaskTLS {
 
 impl Clone for TaskTLS {
 	fn clone(&self) -> Self {
-		TaskTLS::new(environment::get_tls_memsz())
+		TaskTLS::from_environment()
 	}
 }
 
@@ -244,7 +244,7 @@ extern "C" fn task_entry(func: extern "C" fn(usize), arg: usize) {
 		// Yes, it does, so we have to allocate TLS memory.
 		// Allocate enough space for the given size and one more variable of type usize, which holds the tls_pointer.
 		let tls_allocation_size = tls_size + mem::size_of::<usize>();
-		let tls = TaskTLS::new(tls_allocation_size);
+		let tls = TaskTLS::from_environment();
 
 		// The tls_pointer is the address to the end of the TLS area requested by the task.
 		let tls_pointer = tls.address + tls_size;

src/arch/x86_64/kernel/scheduler.rs

@@ -244,7 +244,8 @@ pub struct TaskTLS {
 }
 
 impl TaskTLS {
-	pub fn new(tls_size: usize) -> Self {
+	fn from_environment() -> Self {
+		let tls_size = environment::get_tls_memsz();
 		// determine the size of tdata (tls without tbss)
 		let tdata_size: usize = environment::get_tls_filesz();
 		// Yes, it does, so we have to allocate TLS memory.
@@ -310,7 +311,7 @@ impl Drop for TaskTLS {
 
 impl Clone for TaskTLS {
 	fn clone(&self) -> Self {
-		TaskTLS::new(environment::get_tls_memsz())
+		TaskTLS::from_environment()
 	}
 }
 
@@ -347,11 +348,9 @@ extern "C" fn task_entry(func: extern "C" fn(usize), arg: usize) -> ! {
 
 impl TaskFrame for Task {
 	fn create_stack_frame(&mut self, func: extern "C" fn(usize), arg: usize) {
-		// Check if the task (process or thread) uses Thread-Local-Storage.
-		let tls_size = environment::get_tls_memsz();
-		// check is TLS is already allocated
-		if self.tls.is_none() && tls_size > 0 {
-			self.tls = Some(TaskTLS::new(tls_size))
+		// Check if TLS is allocated already and if the task uses thread-local storage.
+		if self.tls.is_none() && environment::get_tls_memsz() > 0 {
+			self.tls = Some(TaskTLS::from_environment());
 		}
 
 		unsafe {