Add Aarch64 test #16
Merged
Add Aarch64 test #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently only used on aarch64 anyway. Note: If the default x86 binary is used, rusty-loader will fail during the assertion of the elf header machine type. Signed-off-by: Jonathan Schwender <[email protected]>
This test compiles the rusty-loader with an application artifact compiled from jschwe/libhermit-rs@f5faa6d The artifact is technically the rusty_demo artifact, since the hello_world artifact didn't work for me. This is most likely due to the loader still being brittle. I suspect that the copying process is buggy, since (un)commenting simple things such as log messages in rusty-loader will break or fix entry into the kernel. Until this is fixed this workflow will probably fail sometimes. Signed-off-by: Jonathan Schwender <[email protected]>
Apparently make doesn't understand quotes and just passes them along which causes problems with include_env! `error: couldn't read src/arch/aarch64/"/home/jona/rusty-hermit/loader/data/hello_world_aarch64": No such file or directory (os error 2)` Removing the quotes fixes this. Signed-off-by: Jonathan Schwender <[email protected]>
Parts of this commit (especially link.ld) are more or less directly taken from https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/16_virtual_mem_part4_higher_half_kernel/src/bsp/raspberrypi/link.ld (MIT License). I'm not sure if we want to (or already) do virtual addressing in the loader, so I'm sticking to the physical part for now. Anyway this seems to fix the problem I had, where the kernel_start and kernel_end _addresses_ seemingly changed at runtime! Signed-off-by: Jonathan Schwender <[email protected]>
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an aarch64 artifact of the hermit application (for use with the github workflow) that will exit once it reaches the point up to which the kernel currently works. Expected Output is something like:
This test compiles the rusty-loader with an application artifact compiled from
jschwe/libhermit-rs@f5faa6d
The artifact is technically the rusty_demo artifact, since the hello_world artifact
didn't work for me.
This is most likely due to the loader still being brittle.I suspect that the copying process is buggy, since (un)commenting simple things
such as log messages in rusty-loader will break or fix entry into the kernel.
Until this is fixed this workflow will probably fail sometimes.
Update: Commit ae3308c changes the way the Stack pointer is set and this seems to fix the issues I'd been having.