simplify find_kernel for x86_64 #376
Open
+63
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we want to page a range rather than a certain number of pages, use map_page to eliminate the need to calculate the page count.
containing_page calls already align the addresses down. As such, we do not need to align the addresses down ourselves.
Instead of checking if it is the first iteration of the loop in every iteration, handle the first iteration of the modules iterator outside the loop.
cagatay-y
force-pushed
the
find-kernel
branch
2 times, most recently
from
c909766
to
420b9e8
Compare
cagatay-y
commented
Oct 1, 2024
| for m in modules { | ||
| found_module = true; | ||
|
|
||
| if start_address == 0 { |
There was a problem hiding this comment.
I assumed this line is to check if this is the first iteration of the loop (because the variable is initialized to 0) but if it is possible that some of the modules have 0 as their start value, my assumption is incorrect and the new code behaves differently. I don't think that is possible, though.
|
If you think these commits are best for reviewing, we don't have to squash before merging. That way it will remain easy to review in the future. :) |
cagatay-y
force-pushed
the
find-kernel
branch
2 times, most recently
from
e15f3bf
to
afa33dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are very small to ease review and I think at least some of them can be squashed before merging. If we decide not to squash them all into a single commit, I need to push the commits one-by-one for CI before merging.