-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to compile with Angular 8 #7
Comments
`InternalNgModuleRef` is no longer exported from `@angular/core`. This solution simply redefines it. Solves herodevs#7.
Angular 8 prod build fails with following error : ERROR in node_modules/@herodevs/dynamic-af/lib/dynamic-af.service.d.ts(2,37): error TS2307: Cannot find module '@angular/core/src/linker/ng_module_factory'. |
Any news about this? |
It seems to have been merged, but not yet published to npm. |
I thought I published 2.0.1 to NPM. Are you sure? @wmaurer |
@aaronfrost sorry, my fault. Somehow I've been using lazy-af and not hero-loader. Rather confusing. Maybe the lazy-af package should have a deprecation notice ... ;-) |
@wmaurer I think that most people are still using lazy-af. I need to push a deprecated message to lazy-af so that people can see it and switch to hero-loader. |
Please do, I think that would make a lot of sense. |
any update on this one, I still got this issue, please help |
The
InternalNgModuleRef
interface is no longer exported from@angular/core
.The best solution I can think of is to redefine
InternalNgModuleRef
indynamic-component.service.ts
The text was updated successfully, but these errors were encountered: