Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add GRPC status codes as constants #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominiks
Copy link
Contributor

While working with server side Nakama RPCs I found myself using the suggested grpc status codes and I added them to a constants file as they were not available anywhere before.

I suggest adding them to the NakamaException or alternatively to the Nakama autoload for easy access when working with gRPC. A named enum GRPC could also be used instead of prefixing it to all constants but this is the most 'Godot-way', I think.

Additionally there is the field status_code on NakamaException. I found it somewhat confusing in the beginning as it is not clear from the documentation whether that is http-status code or Godot errors. In Godot the http codes are available as RESPONSE_* constants - would it make sense to rename the property to response_code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant