Suggestion: Add GRPC status codes as constants #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with server side Nakama RPCs I found myself using the suggested grpc status codes and I added them to a constants file as they were not available anywhere before.
I suggest adding them to the
NakamaException
or alternatively to theNakama
autoload for easy access when working with gRPC. A named enumGRPC
could also be used instead of prefixing it to all constants but this is the most 'Godot-way', I think.Additionally there is the field
status_code
onNakamaException
. I found it somewhat confusing in the beginning as it is not clear from the documentation whether that is http-status code or Godot errors. In Godot the http codes are available asRESPONSE_*
constants - would it make sense to rename the property toresponse_code
?