Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect NakamaMultiplayerBridge._match_state assignment #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes incorrect NakamaMultiplayerBridge._match_state assignment #192

wants to merge 1 commit into from

Conversation

RobRuana
Copy link

This pull request fixes two minor issues.

  1. _match_state is never actually updated in NakamaMultiplayerBridge._on_nakama_socket_closed() because the match_state property has a readonly setter
  2. The NakamaSocketAdapter.received_error signal is renamed to connection_error to agree with the NakamaSocket.connection_error signal

@RobRuana
Fixes bad _match_state assignment in NakamaMultiplayerBridge._on_naka…
bf5fa87 
…ma_socket_closed(). Also fixes confusingly named NakamaSocketAdapter.connection_error signal
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek Awaiting requested review from dsnopek

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobRuana @CLAassistant