Heroku-24: Remove libmcrypt4 / libmcrypt-dev #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they were added in #149 only for the PHP buildpack's benefit, however, are no longer used by PHP as of PHP 7.2+: heroku/heroku-buildpack-php@0ce0fc5#diff-a8ff7bd14bd2bddfbf6e7c733a14badb0e7a4d566abbfd4d20948dfc998b6a87L59 The few bindings I could find for other langs are all (a) not popular, (b) in a state of disrepair, eg: https://github.com/tugrul/node-mcrypt (last commit 5 years ago) https://github.com/kingpong/ruby-mcrypt (last commit 7 years ago) (Which is not surprising given much better alternatives exist, such as Sodium, which is already in the base image.) GUS-W-15159536.
dzuelke
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they were added in #149 only for the PHP buildpack's benefit, however, are no longer used by PHP as of PHP 7.2+:
heroku/heroku-buildpack-php@0ce0fc5#diff-a8ff7bd14bd2bddfbf6e7c733a14badb0e7a4d566abbfd4d20948dfc998b6a87L59
The few bindings I could find for other langs are all (a) not popular, (b) in a state of disrepair, eg:
https://github.com/tugrul/node-mcrypt (70 stars, last commit 5 years ago)
https://github.com/kingpong/ruby-mcrypt (22 stars, last commit 7 years ago)
(Which is not surprising given much better alternatives exist, such as Sodium, which is already in the base image.)
Towards #266.
GUS-W-15159536.