Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku-24: Remove libc-client2007e-dev #304

Merged
merged 1 commit into from
May 13, 2024

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented May 13, 2024

Since:

  • It was added in Add libc-client2007e to the stack image #146 along with the libc-client2007e runtime library for use by PHP, however, for PHP's use-case (binary compilation) the headers don't need to be in the build image itself, but can instead be installed during the PHP binary build process.
  • There are no other popular libc-client2007e bindings for languages other than PHP that use these headers. (Compared to the other LDAP library already in the build image, libldap-dev, for which there are several popular bindings - including python-ldap with 1.8 million downloads/month.)

See:
https://packages.ubuntu.com/noble/libc-client2007e-dev

Towards #266.
GUS-W-15159536.

@edmorley edmorley self-assigned this May 13, 2024
@edmorley edmorley marked this pull request as ready for review May 13, 2024 15:19
@edmorley edmorley requested a review from a team as a code owner May 13, 2024 15:19
Since:
- It was added in #146 along with the `libc-client2007e` runtime library
  for use by PHP, however, for PHP's use-case (binary compilation) the
  headers don't need to be in the build image itself, but can instead be
  installed during the PHP binary build process.
- There are no other popular bindings for languages other than PHP that
  use these headers. (Compared to the other LDAP library already in the
  build image, `libldap-dev`, for which there are several popular bindings.)

See:
https://packages.ubuntu.com/noble/libc-client2007e-dev

Towards #266.
GUS-W-15159536.
@edmorley edmorley force-pushed the edmorley/h24-rm-libc-client2007e-dev branch from 2757300 to 852bc24 Compare May 13, 2024 16:46
@edmorley edmorley enabled auto-merge (squash) May 13, 2024 16:47
@edmorley edmorley merged commit c1d6c68 into main May 13, 2024
4 checks passed
@edmorley edmorley deleted the edmorley/h24-rm-libc-client2007e-dev branch May 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants