Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy error about pedantic group priority #33

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jul 16, 2024

With newer versions of Rust, Clippy was failing on main with:

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:23:1
   |
23 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
24 | unwrap_used = "warn"
   | ----------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `pedantic` to a lower priority
   |
23 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

eg:
https://github.com/heroku/buildpacks-apt/actions/runs/9955852891/job/27504486097?pr=32#step:5:188

See also:
heroku/buildpacks-python#184

With newer versions of Rust, Clippy was failing on `main` with:

```
error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:23:1
   |
23 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
24 | unwrap_used = "warn"
   | ----------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `#[deny(clippy::lint_groups_priority)]` on by default
help: to have lints override the group set `pedantic` to a lower priority
   |
23 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
@edmorley edmorley added the skip changelog Skip the check-changelog check label Jul 16, 2024
@edmorley edmorley self-assigned this Jul 16, 2024
@edmorley edmorley marked this pull request as ready for review July 16, 2024 11:31
@edmorley edmorley requested a review from a team as a code owner July 16, 2024 11:31
@edmorley edmorley enabled auto-merge (squash) July 16, 2024 11:32
@edmorley edmorley merged commit 08ea720 into main Jul 16, 2024
6 checks passed
@edmorley edmorley deleted the edmorley/fix-linting branch July 16, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Skip the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants