Use HTTPS instead of SSH for Git submodules #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Git submodules previously used SSH instead of HTTPS, which: - Causes errors in environments where SSH auth isn't configured (such as when people prefer to use HTTPS auth for GitHub, but use a different SSH key for other use-cases, and use a wildcard in the SSH config). - Is unnecessary, given these are public repos so don't need auth to read. This fixes the following errors I get locally: ``` $ git submodule update Cloning into '/Users/emorley/src/buildpacks-jvm/buildpacks/maven/test-apps/heroku-java-getting-started'... [email protected]: Permission denied (publickey). fatal: Could not read from remote repository. ``` GUS-W-13745392.
edmorley
added
the
skip changelog
dzuelke
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Git submodules previously used SSH instead of HTTPS, which:
This fixes the following errors I get locally:
GUS-W-13745392.