Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve framework support #726

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Improve framework support #726

merged 1 commit into from
Sep 25, 2024

Conversation

Malax
Copy link
Member

@Malax Malax commented Sep 25, 2024 •
edited
Loading

Changelog

Added

  • The buildpack will add a default process type if a supported framework is detected and the expected build output is found. This mirrors the same feature from the Maven buildpack. (#726)
  • Support for the Micronaut and Quarkus frameworks. Both previously worked with the buildpack but required some configuration. Unless heavily customized, no build task needs to be specified anymore. (#726)

@Malax Malax force-pushed the malax/gradle-framework-support branch from 62b9e61 to 77cfa54 Compare September 25, 2024 13:45
@Malax Malax force-pushed the malax/gradle-framework-support branch from 77cfa54 to eb4c6ff Compare September 25, 2024 13:52
@Malax Malax marked this pull request as ready for review September 25, 2024 13:52
@Malax Malax requested a review from a team as a code owner September 25, 2024 13:52
colincasey
colincasey reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@colincasey colincasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks fine but some integration tests for these frameworks would be nice as a sanity check. Is there a reason why you didn't add some?

Also, will these frameworks be supported by the Maven buildpack?

buildpacks/gradle/src/framework.rs Show resolved Hide resolved
@Malax
Copy link
Member Author

Malax commented Sep 25, 2024

Also, will these frameworks be supported by the Maven buildpack?

Yes! :)

@Malax Malax enabled auto-merge (squash) September 25, 2024 16:18
@Malax Malax merged commit 85776cc into main Sep 25, 2024
20 checks passed
@Malax Malax deleted the malax/gradle-framework-support branch September 25, 2024 16:29
This was referenced Sep 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colincasey colincasey colincasey approved these changes

Assignees
No one assigned
Labels
buildpack: heroku/gradle buildpack: heroku/java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Malax @colincasey